.Net: Add support for Guid and ObjectID keys in the MongoDB Connector#12827
Merged
Conversation
damieng
changed the title
markwallace-microsoft
approved these changes
Aug 7, 2025
westey-m
reviewed
Aug 12, 2025
westey-m
approved these changes
Aug 12, 2025
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Failure
westey-m
approved these changes
Aug 12, 2025
westey-m
approved these changes
Aug 13, 2025
Contributor
|
@damieng, looks like there's still one unit test failing: |
westey-m
approved these changes
Aug 15, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
4 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
### Motivation and Context The ObjectID and Guid string support work in #12827 did not include support for the method overloads that take an IEnumerable of keys. I suspect this was due to merge/out of sync branches and was then missed with the tests being disabled (they now pass). ### Description Adds the support for Guid and ObjectID keys to the GetAsync, DeleteAsync and UpdateAsync methods that take an IEnumerable. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…microsoft#12827) ### Motivation and Context The MongoDB connector currently only supports string key types. ### Description Adds support for Guid and ObjectId key types to the MongoDB Connector. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com> Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The MongoDB connector currently only supports string key types.
Description
Adds support for Guid and ObjectId key types to the MongoDB Connector.
Contribution Checklist